Maintain consistent element order in exports #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonbartels
approved these changes
Apr 20, 2025
Signed-off-by: Richard Ogin <rogin@users.noreply.github.com>
rogin
force-pushed
the
maint-element-order-exports
branch
from
c944e16 to
8630dde
Compare
gibson9583
approved these changes
Jun 16, 2025
kpalang
approved these changes
Jun 16, 2025
tonygermano
reviewed
Jun 16, 2025
| @@ -9,11 +9,11 @@ | |||
|
|
|||
| package com.mirth.connect.donkey.model.message; | |||
|
|
|||
| import java.util.HashMap; | |||
| import java.util.TreeMap; | |||
There was a problem hiding this comment.
Since a TreeMap is sorted and a HashMap is not, I'm guessing there could be considerable changes compared to a prior export the first time an export is done with the new code?
| @@ -53,7 +53,7 @@ public void marshal(Object value, HierarchicalStreamWriter writer, MarshallingCo | |||
| try { | |||
| DonkeyElement mapElement = new DonkeyElement(serializedMap); | |||
| mapElement.setNodeName("content"); | |||
| mapElement.setAttribute("class", "map"); | |||
| mapElement.setAttribute("class", "tree-map"); | |||
There was a problem hiding this comment.
what exactly does this impact?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an old and common complaint. Previous test results here. I've only verified that it built successfully using Java 8.